Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23429 )
Change subject: Adapting to OpenSSL 3.x ...................................................................... Patch Set 2: (5 comments) Thanks for working on this. http://gerrit.cloudera.org:8080/#/c/23429/2/src/kudu/security/crypto.cc File src/kudu/security/crypto.cc: http://gerrit.cloudera.org:8080/#/c/23429/2/src/kudu/security/crypto.cc@334 PS2, Line 334: EVP_PKEY_CTX* ctx Use ssl_make_unique to wrap raw pointers, making the code more concise, less memory-leak- and error-prone. http://gerrit.cloudera.org:8080/#/c/23429/2/src/kudu/security/crypto.cc@347 PS2, Line 347: EVP_PKEY_keygen Isn't it necessary to call EVP_PKEY_keygen_init() prior to calling EVP_PKEY_keygen() here? http://gerrit.cloudera.org:8080/#/c/23429/2/src/kudu/security/crypto.cc@347 PS2, Line 347: rc = It seems error handling is missing here: what if EVP_PKEY_keygen() returns an error? http://gerrit.cloudera.org:8080/#/c/23429/2/src/kudu/util/jwt-util.cc File src/kudu/util/jwt-util.cc: http://gerrit.cloudera.org:8080/#/c/23429/2/src/kudu/util/jwt-util.cc@471 PS2, Line 471: EVP_PKEY_CTX* ctx Wrap into ssl_make_unique? http://gerrit.cloudera.org:8080/#/c/23429/2/src/kudu/util/jwt-util.cc@649 PS2, Line 649: EVP_PKEY_CTX* ctx = EVP_PKEY_CTX_new_from_name Create a corresponding trait and wrap this into ssl_make_unique? -- To view, visit http://gerrit.cloudera.org:8080/23429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic587a85e6b9088ffd353f9119b75431f1ec60b5c Gerrit-Change-Number: 23429 Gerrit-PatchSet: 2 Gerrit-Owner: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 17 Sep 2025 07:35:31 +0000 Gerrit-HasComments: Yes
