Hello Xuebin Su, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23220
to look at the new patch set (#10).
Change subject: WIP KUDU-1261 add GetArray/SetArray C++ client API
......................................................................
WIP KUDU-1261 add GetArray/SetArray C++ client API
This patch adds methods into the Kudu client C++ API to set an array
of values for all the supported scalar types except for
INT128 and DECIMAL128. End-to-end writing/reading works when
the data is stored at the server side in both MRS and array data blocks
on the disk.
Also, added KuduScanBatch::RowPtr::GetArrayInt{8,16,32,64} methods,
but didn't add enough tests for those yet.
This changelist also contains new test scenarios in
client-test.cc to cover the newly added functionality.
Added src/kudu/client/array_cell.h with KuduArrayCellView API
to access raw data in array cells. That's oriented to working with
raw data access API such as KuduScanBatch::RowPtr::cell() and
KuduScanBatch::direct_data(); AFAIK, that's what Impala uses to fetch
scan results from Kudu.
WIP:
* clarify on the signature of the methods
* add proper commit description with all the details
* add documentation (Doxygen) for the newly introduced methods
* add the rest of GetArray methods for KuduScanBatch::RowPtr
Change-Id: I3028b5bebc5341303fef02be656acb47b8523890
---
M src/kudu/client/CMakeLists.txt
A src/kudu/client/array_cell-internal.cc
A src/kudu/client/array_cell.h
M src/kudu/client/client-test.cc
M src/kudu/client/scan_batch.cc
M src/kudu/client/scan_batch.h
M src/kudu/common/partial_row-test.cc
M src/kudu/common/partial_row.cc
M src/kudu/common/partial_row.h
M src/kudu/common/types.h
M src/kudu/integration-tests/decimal-itest.cc
11 files changed, 1,173 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/23220/10
--
To view, visit http://gerrit.cloudera.org:8080/23220
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3028b5bebc5341303fef02be656acb47b8523890
Gerrit-Change-Number: 23220
Gerrit-PatchSet: 10
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Xuebin Su <[email protected]>
