Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22867 )
Change subject: KUDU-1973: Send no-op heartbeat operations batched - PART 1 ...................................................................... Patch Set 19: (2 comments) I fixed a bug introduced in rev 16,17. If the MultiRaftHeartbeatBatcher gets deleted due to config change, not because shutdown/table deletion, we are on the raft pool thread, and we should not destroy the token. Solution: Just keep the token for hosts we stopped having followers from. If we get a follower again, we reuse the token. http://gerrit.cloudera.org:8080/#/c/22867/17/src/kudu/consensus/multi_raft_consensus_data.h File src/kudu/consensus/multi_raft_consensus_data.h: http://gerrit.cloudera.org:8080/#/c/22867/17/src/kudu/consensus/multi_raft_consensus_data.h@63 PS17, Line 63: if (req.has_preceding_id()) { : > style nit: fix the curly bracket placement Done http://gerrit.cloudera.org:8080/#/c/22867/15/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/22867/15/src/kudu/tserver/tablet_service.cc@1830 PS15, Line 1830: } > OK, but 'const auto&' would work here as well. The main point was to have Done -- To view, visit http://gerrit.cloudera.org:8080/22867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie92ba4de5eae00d56cd513cb644dce8fb6e14538 Gerrit-Change-Number: 22867 Gerrit-PatchSet: 19 Gerrit-Owner: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Sun, 28 Sep 2025 23:08:58 +0000 Gerrit-HasComments: Yes
