Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23259 )
Change subject: [build][java] KUDU-3681: Move to JDK17 ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/23259/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23259/1//COMMIT_MSG@7 PS1, Line 7: Move to JDK17 > Correction: I tested building Kudu with Hive 4.1.0 and JDK11, it does not c I see: thanks a lot for elaborating on these details. OK, then I don't see a lot of room for step-by-step transition. But I might be missing something, so maybe it makes sense to ask for more feedback from people with Java background (Attila?), just in case. http://gerrit.cloudera.org:8080/#/c/23259/1//COMMIT_MSG@11 PS1, Line 11: The changes: > * No, I attempted to make the change so that we are JDK8 backwards compatib Thanks for explaining the details! Would it makes sense to add some it in some form into the description of the changelist as well, so it's easier for the posterity to get more context on the way how this is done? http://gerrit.cloudera.org:8080/#/c/23259/1//COMMIT_MSG@18 PS1, Line 18: upgrade the Hive dependency to 4.1.0 > Hive 4.1.0 doesn't compile with JDK 11, do you have a source that states > otherwise? I asked this question to one of the LLM chatbots, and it was quite positive that Hive 4 compiles with JDK 11 :) I haven't verified it myself, and I wouldn't be surprised it was wrong :) However, maybe it's indeed true for Hive 4.0.0 and then it would be possible to have JDK8 --> JDK11 --> JDK17 transition, while updating Hive gradually? Did you consider checking out such an option? Thanks! http://gerrit.cloudera.org:8080/#/c/23259/1/java/kudu-spark/build.gradle File java/kudu-spark/build.gradle: http://gerrit.cloudera.org:8080/#/c/23259/1/java/kudu-spark/build.gradle@35 PS1, Line 35: testImplementation libs.junit > sorry, this is a leftover of a fix that didn't work/wasn't needed, removing Ah, np -- I feel relief knowing that's just a left-over :) Thank you for the explanation! -- To view, visit http://gerrit.cloudera.org:8080/23259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f73c0d3a79e1c37b12a173881273b4b68d718b3 Gerrit-Change-Number: 23259 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 30 Sep 2025 05:31:57 +0000 Gerrit-HasComments: Yes
