Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23429 )
Change subject: OpenSSL 3.x compatibility adaptation ...................................................................... Patch Set 18: Code-Review+2 (1 comment) Almost there. If you have a bit more time to invest in this patch, please address one more nit in jwt-util.cc -- sorry, I didn't notice in earlier review rounds. Thanks a lot! http://gerrit.cloudera.org:8080/#/c/23429/18/src/kudu/util/jwt-util.cc File src/kudu/util/jwt-util.cc: http://gerrit.cloudera.org:8080/#/c/23429/18/src/kudu/util/jwt-util.cc@658 PS18, Line 658: // OSSL_PKEY_PARAM_PUB_KEY is a well-known constant name provided by OpenSSL 3.0 : // headers (openssl/core_names.h). It is a compile-time constant pointer to a : // string literal and should never be null at runtime. This check documents the : // assumption and will DCHECK in debug builds if the headers are inconsistent. : OPENSSL_CHECK_OK(OSSL_PKEY_PARAM_PUB_KEY != nullptr); nit: IIUC, this isn't only for debug builds -- this end up as an extra operation in release builds as well since OPENSSL_CHECK_OK() uses CHECK_GT, not DCHECK_GT. If this is a compile-time verification, maybe use static_assert() here instead and spare a few CPU cycles in runtime? https://en.cppreference.com/w/cpp/language/static_assert.html -- To view, visit http://gerrit.cloudera.org:8080/23429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic587a85e6b9088ffd353f9119b75431f1ec60b5c Gerrit-Change-Number: 23429 Gerrit-PatchSet: 18 Gerrit-Owner: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yan-Daojiang <[email protected]> Gerrit-Comment-Date: Wed, 15 Oct 2025 16:05:16 +0000 Gerrit-HasComments: Yes
