Alexey Serbin has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/23552


Change subject: KUDU-1261 array columns aren't yet supported as key columns
......................................................................

KUDU-1261 array columns aren't yet supported as key columns

This changelist adds a guardrail to explicitly disallow creating Kudu
tables with array key columns.  This artificial restriction is added
to prevent unexpected behavior since a proper encoding for array column
cells isn't implemented yet.  A new unit test to verify the expected
behavior is added as well.

As a bit of context, to properly encode an array cell, it's necessary
to make sure that:
  * the contents of the memory buffer backing the cell is 'normalized',
    i.e. the interpretation of null/non-valid elements of a particular
    type is always the same when feeding data to the encoder
  * run the encoder against the sub-range of the memory buffer that
    contains array elements' data only, and not include metadata, etc.

Change-Id: If37a4dd2d1689aa51ab09e6cb71f01664dc2ee1a
---
M src/kudu/common/key_encoder.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
3 files changed, 67 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/23552/1
--
To view, visit http://gerrit.cloudera.org:8080/23552
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If37a4dd2d1689aa51ab09e6cb71f01664dc2ee1a
Gerrit-Change-Number: 23552
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>

Reply via email to