Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23531 )
Change subject: KUDU-3708 Create Python example for array datatype ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/23531/1/examples/python/basic-python-example/array_example.py File examples/python/basic-python-example/array_example.py: http://gerrit.cloudera.org:8080/#/c/23531/1/examples/python/basic-python-example/array_example.py@30 PS1, Line 30: - A regular INT32 column (int_val) : - Array columns for INT64, STRING, and DOUBLE types : """ : builder = kudu.schema_builder() : builder.add_column('key').type(kudu.int32).nullable(False).primary_key() : builder.add_column('int_val', type_=kudu.int32, nullable=False) : > Good point! I added modular functions (create_schema(), insert_rows(), scan Its fine this way. http://gerrit.cloudera.org:8080/#/c/23531/1/examples/python/basic-python-example/array_example.py@89 PS1, Line 89: : scanner.open() : row_count = 0 : while scanner.has_more_rows(): > This error handling pattern is copied from basic_example.py and non_unique_ Thank you. If you have the time, it would be nice to update the others too. -- To view, visit http://gerrit.cloudera.org:8080/23531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a84ee9731efdc802673bb964d358b07648b3fae Gerrit-Change-Number: 23531 Gerrit-PatchSet: 3 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Wed, 15 Oct 2025 16:11:42 +0000 Gerrit-HasComments: Yes
