Marton Greber has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/23494 )
Change subject: KUDU-1261 Python array datatype fixes
......................................................................
KUDU-1261 Python array datatype fixes
- When setting an array, added reserve since the size is known
beforehand.
- Added support for decimal type:
- If precision <= 9 → use Int32 SetArrayUnscaledDecimal.
- Else If precision <= 18 → use Int64 SetArrayUnscaledDecimal.
- Added type_to_string function to ColumnSchema (new addition).
- Updated the Schema.__repr__ function to properly cover array types.
- Added tests for stringification.
- Updated test cases to cover decimal types.
- Added a test case for schemas with array columns containing only
None values.
- Added decimal array tests for both Int32 and Int64 code paths.
Change-Id: I77292b07a854b4f48a75d4e1293f302e8bad9129
Reviewed-on: http://gerrit.cloudera.org:8080/23494
Reviewed-by: Alexey Serbin <[email protected]>
Reviewed-by: Gabriella Lotz <[email protected]>
Tested-by: Marton Greber <[email protected]>
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pyx
M python/kudu/tests/test_array_datatype.py
M python/kudu/tests/test_schema.py
5 files changed, 317 insertions(+), 20 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Gabriella Lotz: Looks good to me, but someone else must approve
Marton Greber: Verified
--
To view, visit http://gerrit.cloudera.org:8080/23494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I77292b07a854b4f48a75d4e1293f302e8bad9129
Gerrit-Change-Number: 23494
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Gabriella Lotz <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
