Hello Marton Greber, Riza Suminto, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23490
to look at the new patch set (#2).
Change subject: KUDU-1261 instantiate templates for RowPtr::GetArray()
......................................................................
KUDU-1261 instantiate templates for RowPtr::GetArray()
This patch adds KuduScanBatch::RowPtr::GetArray<>() template
instantiations for all the necessary column data types.
Since Kudu C++ client API still officially supports C++98, it's
necessary to have template instantiations for RowPtr::GetArray(),
similar to RowPtr::Get() for non-array getters. Otherwise, there
might be linker errors: see [1] for details.
This patch also contains a fix for a crash if trying to read an empty
boolean array using the RowPtr::GetArray typed accessor.
The corresponding end-to-end tests are included in client-test.cc,
along with scenarios of calling the RowPtr::GetArray() on a column
that is a null array.
[1] https://isocpp.org/wiki/faq/templates#separate-template-fn-defn-from-decl
Change-Id: I50b36c48959b00874921c6b56d210cf7358619f4
---
M src/kudu/client/client-test.cc
M src/kudu/client/scan_batch.cc
M src/kudu/client/scan_batch.h
M src/kudu/common/partial_row.h
4 files changed, 404 insertions(+), 38 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/23490/2
--
To view, visit http://gerrit.cloudera.org:8080/23490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I50b36c48959b00874921c6b56d210cf7358619f4
Gerrit-Change-Number: 23490
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
