Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23509 )
Change subject: KUDU-3478 Add Python client examples test script ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/23509/1/python/Makefile File python/Makefile: http://gerrit.cloudera.org:8080/#/c/23509/1/python/Makefile@25 PS1, Line 25: ifdef TEST : python -m unittest $(TEST) : else : python setup.py test : endif > Does it make sense to run test-python-examples.sh here as a part of the 'te Personally I use `make test` in the Python folder to quickly run all the tests. I wouldn't say that running examples in this context is that important. The main goal is that at least in CI it should be ran. Moreover if a client facing change is made, we can always run the example verification script locally 'by hand'. http://gerrit.cloudera.org:8080/#/c/23509/1/python/test-python-examples.sh File python/test-python-examples.sh: http://gerrit.cloudera.org:8080/#/c/23509/1/python/test-python-examples.sh@152 PS1, Line 152: local valid=false : for example in "${VALID_EXAMPLES[@]}"; do : if [[ "$EXAMPLE_NAME" == "$example" ]]; then : valid=true : break : fi : done : if [[ "$valid" != "true" ]]; then : exit_error "Invalid example script: $EXAMPLE_NAME. Must be one of: ${VALID_EXAMPLES[*]}" : fi > Does this work? Good catch, previously I had this in a function and forgot to remove the local. Removed the local keyword. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/23509 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2ea271a8d33a285e4bf222afa17ec77583a5b8b Gerrit-Change-Number: 23509 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Thu, 09 Oct 2025 15:11:07 +0000 Gerrit-HasComments: Yes
