Yan-Daojiang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23429 )
Change subject: OpenSSL 3.x compatibility adaptation ...................................................................... Patch Set 18: > Patch Set 12: > > (2 comments) > > Thank you for the update! Now this can be successfully built on my ubuntu > 24.04 LTS build machine. > > This patch now looks good to me, there is just one question and a request to > move in-line documentation, if the change in SCOPED_OPENSSL_NO_PENDING_ERRORS > location is indeed still necessary. Thank you for the thorough review and for confirming the build is now successful! The latest update is PS18. You are absolutely correct that macros themselves don't require forward declarations. The original problem was a conflicting iwyu check reported on the community Jenkins build versus my local Ubuntu 24.04 environment. The conflict was specifically about whether the forward declaration for ScopedCheckNoPendingSSLErrors was needed in that header. It seems the platform difference lies in how iwyu interprets "uses" of a type inside a macro body. I suspect that different versions or environments of iWYU may see this as a reason for needing a forward declaration, but the results may be inconsistent. To definitively resolve this platform-dependent iwyu check, I have further adjusted the IWYU pragmas in the latest patch. This should align the static analysis across all environments. For the macro I moved it back to its original location. Thank you again for your careful and insightful review. -- To view, visit http://gerrit.cloudera.org:8080/23429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic587a85e6b9088ffd353f9119b75431f1ec60b5c Gerrit-Change-Number: 23429 Gerrit-PatchSet: 18 Gerrit-Owner: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yan-Daojiang <[email protected]> Gerrit-Comment-Date: Wed, 15 Oct 2025 11:46:29 +0000 Gerrit-HasComments: No
