Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22867 )
Change subject: KUDU-1973: Send no-op heartbeat operations batched - PART 1 ...................................................................... Patch Set 21: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/22867/21/src/kudu/consensus/multi_raft_batcher.cc File src/kudu/consensus/multi_raft_batcher.cc: http://gerrit.cloudera.org:8080/#/c/22867/21/src/kudu/consensus/multi_raft_batcher.cc@59 PS21, Line 59: " nit for here and below: add a space before the double quote, otherwise this current code will result in a garbled flag description since there isn't spaces between the lines concatenated by the pre-processor/compiler http://gerrit.cloudera.org:8080/#/c/22867/21/src/kudu/consensus/multi_raft_batcher.cc@286 PS21, Line 286: batchers_.insert({hostport, BatcherAndPoolToken(batcher, raft_pool_token)}); Could it happen that nothing is inserted because the batch with that key is present, but an attempt to lock/promote it failed at line 276? Does it make sense to make sure a new batcher is inserted, or this is intended behavior when nothing would be inserted because of the condition mentioned? -- To view, visit http://gerrit.cloudera.org:8080/22867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie92ba4de5eae00d56cd513cb644dce8fb6e14538 Gerrit-Change-Number: 22867 Gerrit-PatchSet: 21 Gerrit-Owner: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Mon, 29 Sep 2025 18:29:25 +0000 Gerrit-HasComments: Yes
