Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/23224 )
Change subject: Add OpenAPI specification for REST API endpoints ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/23224/3/src/kudu/master/rest_catalog_path_handlers.cc File src/kudu/master/rest_catalog_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/23224/3/src/kudu/master/rest_catalog_path_handlers.cc@233 PS3, Line 233: } : : resp->status_code = HttpStatusCode::Ok; : } : : void RestCatalogPathHandlers::HandleApiSpecEndpoint(const Webserver::WebRequest& req, : Webserver::PrerenderedWebResponse* resp) { : if (req.request_method != "GET") { : resp->status_code = HttpStatusCode::MethodNotAllowed; : resp->output << "Method not allowed"; : return; : } > Usually on secure deployments the webserver is accessed through Apache Knox I tested it, and by making the documentation read-only, I managed to get it to work with Apache Knox as of the latest patch-set. The Try it out button won't really work with that case, since the request URL is missing the query parameters. I also rewrote the documentation into a mustache template instead of the redirection approach to make this work. For this reason I had to remove the Swagger/OpenAPI navbar, since there was already Kudu UI's navbar on top of the page. -- To view, visit http://gerrit.cloudera.org:8080/23224 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3981665c78f478e89d0300f3a2fc5d68b73b8762 Gerrit-Change-Number: 23224 Gerrit-PatchSet: 5 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 08 Oct 2025 08:23:33 +0000 Gerrit-HasComments: Yes
