Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23477 )
Change subject: KUDU-1973 Fix caching in MultiRaftManager. ...................................................................... KUDU-1973 Fix caching in MultiRaftManager. Currently, if another TServer disappears or we stop having followers on it for any consensus, and later we need batching for it again, the batcher is not cached, and every Raft consensus gets a distinct batcher. This defeats the whole purpose of the feature and loses the performance improvements. However, this bug still allows Raft to work correctly, which is why unit tests are green even with --enable_multi_raft_heartbeat_batcher=1. Also adding spaces to the multi_raft_heartbeat_window_ms flag description. Change-Id: I254217d7099f8b773868df5724b78123bd49a287 Reviewed-on: http://gerrit.cloudera.org:8080/23477 Reviewed-by: Zoltan Chovan <[email protected]> Reviewed-by: Attila Bukor <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Attila Bukor <[email protected]> --- M src/kudu/consensus/multi_raft_batcher.cc 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Zoltan Chovan: Looks good to me, but someone else must approve Attila Bukor: Looks good to me, approved; Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/23477 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I254217d7099f8b773868df5724b78123bd49a287 Gerrit-Change-Number: 23477 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]>
