Marton Greber has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23451 )

Change subject: KUDU-3662 [6/n] Add sink table initialization
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23451/1/java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationTableInitializer.java
File 
java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationTableInitializer.java:

http://gerrit.cloudera.org:8080/#/c/23451/1/java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationTableInitializer.java@55
PS1, Line 55: sourceClient = new KuduClient.KuduClientBuilder(
            :             String. join(",", 
config.getSourceMasterAddresses())).build();
            :     sinkClient = new KuduClient.KuduClientBuilder(
            :             String.join(",", 
config.getSinkMasterAddresses())).build();
            :     sourceTableName = config.getTableName();
            :     sinkTableName = config.getSinkTableName();
            :     restoreOwner = config.getRestoreOwner();
> yeah, sorry, the clients are fine, the last three variables are what I want
removed the 3 config params, replaced with getters.



--
To view, visit http://gerrit.cloudera.org:8080/23451
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1002b4ba272c1acaab351e3ff3f341ca327070d2
Gerrit-Change-Number: 23451
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Comment-Date: Thu, 25 Sep 2025 11:00:17 +0000
Gerrit-HasComments: Yes

Reply via email to