Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23521 )
Change subject: KUDU-1261 Add HMS integration for array datatype ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Thank you for the fix. Overall looks good to me, but there is one nit to address. I guess we will need to add more end-to-end tests to cover array-related theme in HMS integration, but that's, of course, is a theme on its own. http://gerrit.cloudera.org:8080/#/c/23521/1/src/kudu/hms/hms_catalog.cc File src/kudu/hms/hms_catalog.cc: http://gerrit.cloudera.org:8080/#/c/23521/1/src/kudu/hms/hms_catalog.cc@359 PS1, Line 359: const auto* nested_type_info = type_info->nested_type_info(); : DCHECK(nested_type_info); : DCHECK(nested_type_info->is_array()); : const auto& array_info = nested_type_info->array(); : const TypeInfo* elem_type_info = array_info.elem_type_info(); : DCHECK(elem_type_info); Consider using GetArrayElementTypeInfo(*type_info) instead of this. -- To view, visit http://gerrit.cloudera.org:8080/23521 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab1d4c0920043c213757d35ea7bf721a06e8cf44 Gerrit-Change-Number: 23521 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 09 Oct 2025 16:10:12 +0000 Gerrit-HasComments: Yes
