Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23501 )
Change subject: [thirdparty] explicit include directive for gumbo-query ...................................................................... [thirdparty] explicit include directive for gumbo-query There were reports that building Kudu as a part of Impala's toolchain on Ubuntu 24.04 LTS would fail on compiling gumbo-query because the necessary include directory directive -I$PREFIX/include was not added by CMake, while it should have been present. Getting to the bottom of the issue might be time-consuming, but adding the include directory explicitly is easy and shouldn't hurt since we already do so when building glog at least. Change-Id: I65b8a6d3b63ff6684e2ed8579b01f25c243ffc66 Reviewed-on: http://gerrit.cloudera.org:8080/23501 Reviewed-by: Marton Greber <[email protected]> Tested-by: Marton Greber <[email protected]> Reviewed-by: Gabriella Lotz <[email protected]> --- M thirdparty/build-definitions.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Marton Greber: Looks good to me, approved; Verified Gabriella Lotz: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/23501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I65b8a6d3b63ff6684e2ed8579b01f25c243ffc66 Gerrit-Change-Number: 23501 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]>
