Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23429 )
Change subject: OpenSSL 3.x compatibility adaptation ...................................................................... Patch Set 9: (5 comments) Almost there. Please address compilation failure on Ubuntu24.04 LTS with OpenSSL 3.0.13 and a few style nits. Thanks a lot for updating the patch! http://gerrit.cloudera.org:8080/#/c/23429/9/src/kudu/security/crypto.cc File src/kudu/security/crypto.cc: http://gerrit.cloudera.org:8080/#/c/23429/9/src/kudu/security/crypto.cc@359 PS9, Line 359: return Status::OK(); nit: move this and same return statement at line 373 out of the #if ... #else ... #endif to become common code? http://gerrit.cloudera.org:8080/#/c/23429/9/src/kudu/util/jwt-util.cc File src/kudu/util/jwt-util.cc: http://gerrit.cloudera.org:8080/#/c/23429/9/src/kudu/util/jwt-util.cc@503 PS9, Line 503: #endif style/readability nit for here and elsewhere for page-long #if ... #else ... #endif blocks like this: consider adding in-line comments for #else and #endif to understand what's the context of the block; as an example, please take a look at https://gerrit.cloudera.org/#/c/23429/9/src/kudu/util/openssl_util.cc@283 http://gerrit.cloudera.org:8080/#/c/23429/9/src/kudu/util/jwt-util.cc@613 PS9, Line 613: auto x = bn_from_bytes(ascii_x); : auto y = bn_from_bytes(ascii_y); nit: these two lines and lines 684-685 are exactly the same; maybe move them out of #if ... #else ... #endif to become common? http://gerrit.cloudera.org:8080/#/c/23429/9/src/kudu/util/jwt-util.cc@669 PS9, Line 669: style nit: since it's a continuation of previous line, add two more spaces to match the rest of the code http://gerrit.cloudera.org:8080/#/c/23429/9/src/kudu/util/openssl_util.h File src/kudu/util/openssl_util.h: http://gerrit.cloudera.org:8080/#/c/23429/9/src/kudu/util/openssl_util.h@226 PS9, Line 226: static constexpr auto kFreeFunc = &OSSL_PARAM_BLD_free; This doesn't compile on Ubuntu24.04 LTS: In file included from src/kudu/util/env_posix.cc:65: src/kudu/util/openssl_util.h:226:38: error: ‘OSSL_PARAM_BLD_free’ was not declared in this scope; did you mean ‘OSSL_PARAM_free’? 226 | static constexpr auto kFreeFunc = &OSSL_PARAM_BLD_free; | ^~~~~~~~~~~~~~~~~~~ | OSSL_PARAM_free make[2]: *** [src/kudu/util/CMakeFiles/kudu_util_exported.dir/build.make:356: src/kudu/util/CMakeFiles/kudu_util_exported.dir/env_posix.cc.o] Error 1 make[2]: *** Waiting for unfinished jobs.... Information on the OpenSSL library at the build machine: OpenSSL 3.0.13 30 Jan 2024 (Library: OpenSSL 3.0.13 30 Jan 2024) The compilation error is the same if using the system GCC/G++ 13.3 or CLANG from Kudu's 3rd-party to compile the project. -- To view, visit http://gerrit.cloudera.org:8080/23429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic587a85e6b9088ffd353f9119b75431f1ec60b5c Gerrit-Change-Number: 23429 Gerrit-PatchSet: 9 Gerrit-Owner: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yan-Daojiang <[email protected]> Gerrit-Comment-Date: Sun, 12 Oct 2025 16:35:51 +0000 Gerrit-HasComments: Yes
