Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23482 )
Change subject: KUDU-1261 [Java] Add write support for Array Type ...................................................................... Patch Set 7: (1 comment) Just one high-level comment for starters. http://gerrit.cloudera.org:8080/#/c/23482/7/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java File java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java: http://gerrit.cloudera.org:8080/#/c/23482/7/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java@93 PS7, Line 93: public byte getInt8(int i) { : ensureTag(ScalarArray.Int8Array, "INT8"); : if (!isValid(i)) { : throw new IllegalStateException("Element " + i + " is NULL"); : } : Int8Array arr = new Int8Array(); : content.data(arr); : return arr.values(i); : } In addition to these per-element accessors, does it make sense to provide access to all the elements wrapped in Java container? Otherwise, retrieving the contents of arrays one element at a time isn't quite efficient, I guess. -- To view, visit http://gerrit.cloudera.org:8080/23482 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbe5e243eafe12a8977d40204dacab99624451eb Gerrit-Change-Number: 23482 Gerrit-PatchSet: 7 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 03 Oct 2025 18:48:01 +0000 Gerrit-HasComments: Yes
