Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23485 )
Change subject: KUDU-1261 Add array type support to Python client ...................................................................... Patch Set 1: (5 comments) Revved the patch to address the issue with empty BOOL array, re-basing it on the top of the fix, addressed a few nits. http://gerrit.cloudera.org:8080/#/c/23485/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23485/1//COMMIT_MSG@30 PS1, Line 30: - Fix: Empty BOOL array read triggers C++ assertion failure : (requires C++ client fix) > The current C++'s client's test coverage is spotty, indeed. I'll work on a Done http://gerrit.cloudera.org:8080/#/c/23485/1//COMMIT_MSG@30 PS1, Line 30: - Fix: Empty BOOL array read triggers C++ assertion failure : (requires C++ client fix) > Alright, this is fixed with http://gerrit.cloudera.org:8080/23490 Done http://gerrit.cloudera.org:8080/#/c/23485/1/python/kudu/client.pyx File python/kudu/client.pyx: http://gerrit.cloudera.org:8080/#/c/23485/1/python/kudu/client.pyx@3472 PS1, Line 3472: > nit: remove stray spaces Done http://gerrit.cloudera.org:8080/#/c/23485/1/python/kudu/libkudu_client.pxd File python/kudu/libkudu_client.pxd: http://gerrit.cloudera.org:8080/#/c/23485/1/python/kudu/libkudu_client.pxd@473 PS1, Line 473: > nit: remove the trailing space Done http://gerrit.cloudera.org:8080/#/c/23485/1/python/kudu/tests/test_array_datatype.py File python/kudu/tests/test_array_datatype.py: http://gerrit.cloudera.org:8080/#/c/23485/1/python/kudu/tests/test_array_datatype.py@259 PS1, Line 259: # Skip bool. : # TODO: empty BOOL arrays cause C++ Client assertion failure : if type_name == 'bool': : continue > With http://gerrit.cloudera.org:8080/23490 it's no longer necessary to skip Done -- To view, visit http://gerrit.cloudera.org:8080/23485 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2329c7466534bd4961860c05b600e7d4b4a11507 Gerrit-Change-Number: 23485 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Fri, 03 Oct 2025 20:35:47 +0000 Gerrit-HasComments: Yes
