Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type ...................................................................... Patch Set 14: (3 comments) http://gerrit.cloudera.org:8080/#/c/23483/13/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java File java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java: http://gerrit.cloudera.org:8080/#/c/23483/13/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java@75 PS13, Line 75: * <p>If no validity bitmap is present, this corresponds to the : * underlying values vector length.</p> > nit: I'm not sure this brings in more clarity, at least to me it looked a b Removed it. http://gerrit.cloudera.org:8080/#/c/23483/13/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellViewHelper.java File java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellViewHelper.java: http://gerrit.cloudera.org:8080/#/c/23483/13/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellViewHelper.java@270 PS13, Line 270: } else if (precision <= 18) { > nit: fix the indent? Done http://gerrit.cloudera.org:8080/#/c/23483/13/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellViewHelper.java@327 PS13, Line 327: rray.Int64Array: { > nit: I'm not sure this will hold true since it depends on future implementa Done -- To view, visit http://gerrit.cloudera.org:8080/23483 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52 Gerrit-Change-Number: 23483 Gerrit-PatchSet: 14 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 20 Oct 2025 23:10:53 +0000 Gerrit-HasComments: Yes
