Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23559 )
Change subject: KUDU-1261 introduce ARRAY_1D_COLUMN_TYPE feature for tservers ...................................................................... KUDU-1261 introduce ARRAY_1D_COLUMN_TYPE feature for tservers This changelist introduces a new feature flag ARRAY_1D_COLUMN_TYPE for Kudu tablet servers to reflect whether a tablet server is capable of hosting tablets with array columns. Also, the system catalog's code has been updated to require the feature flag when sending requests to create a table with array type columns or altering a table that contains at least one array type column. The rationale behind adding the new feature flag is to make it easier to reason about and troubleshoot situations when a Kudu master of newer version works with tablet servers of prior versions, and the latter ones do not support array type columns. This patch includes test scenarios to provide basic coverage for the newly introduced functionality. As a part of this changelist, I also updated the logic of the catalog manager's RetryingTSRpcTask::RpcCallback() method to not retry sending same RPC to tablet servers again and again if the tablet server responds with 'unsupported feature flags'. This behavior is gated by the newly introduced flag which is set to 'false' by default: --catalog_manager_retry_tserver_task_on_unsupported_feature_flags Change-Id: I07a8e6b6a90a90562e9ad0be35702f21b49d2da5 Reviewed-on: http://gerrit.cloudera.org:8080/23559 Reviewed-by: Abhishek Chennaka <[email protected]> Tested-by: Alexey Serbin <[email protected]> --- M src/kudu/client/service-features-test.cc M src/kudu/master/catalog_manager.cc M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/tserver.proto 5 files changed, 227 insertions(+), 11 deletions(-) Approvals: Abhishek Chennaka: Looks good to me, approved Alexey Serbin: Verified -- To view, visit http://gerrit.cloudera.org:8080/23559 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I07a8e6b6a90a90562e9ad0be35702f21b49d2da5 Gerrit-Change-Number: 23559 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Xuebin Su <[email protected]>
