Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23568 )
Change subject: KUDU-1261 use empty validity vector when no nulls in array ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/23568/2/src/kudu/common/partial_row-test.cc File src/kudu/common/partial_row-test.cc: http://gerrit.cloudera.org:8080/#/c/23568/2/src/kudu/common/partial_row-test.cc@455 PS2, Line 455: (2, {}, {}) What happens if the value is null i.e. if I do row.SetArrayInt32(2, null, {})? Do we want a test case covering that behavior? -- To view, visit http://gerrit.cloudera.org:8080/23568 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f0284a1cdf23234d30d18ae4b9f6ee3a9bd82f4 Gerrit-Change-Number: 23568 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Wed, 22 Oct 2025 16:18:14 +0000 Gerrit-HasComments: Yes
