Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23570 )
Change subject: KUDU-1261 [Java] Add array column support in AlterTableOptions ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/23570/2/java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java File java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java: http://gerrit.cloudera.org:8080/#/c/23570/2/java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java@130 PS2, Line 130: Add a new column that's nullable. Does it make sense to add a note about on using different method for adding array columns? The auto-generated documentation might benefit from clarifying on this. http://gerrit.cloudera.org:8080/#/c/23570/2/java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java@137 PS2, Line 137: if (type == Type.NESTED) { : throw new IllegalArgumentException( : "Use addArrayColumn() for array columns instead of addNullableColumn()."); : } I'm not sure I understand why this is added exclusively here, given there is addColumn() which still accepts Type.NESTED. http://gerrit.cloudera.org:8080/#/c/23570/2/java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java@155 PS2, Line 155: boolean nullable) { Instead of providing this as a parameter, would it make more sense to follow the already existing convention of having addColumn() and addNullableColumn() pair, and name the new methods as addNullableArrayColumn() and addArrayColumn()? -- To view, visit http://gerrit.cloudera.org:8080/23570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22892e1a181f487d3146b1819a5cb0ea56579403 Gerrit-Change-Number: 23570 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 22 Oct 2025 19:10:21 +0000 Gerrit-HasComments: Yes
