Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23482 )
Change subject: KUDU-1261 [Java] Add write support for Array Type ...................................................................... Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/23482/12/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java File java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java: http://gerrit.cloudera.org:8080/#/c/23482/12/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java@43 PS12, Line 43: public final class ArrayCellView > I saw that this is indeed modified to package private in followup patches, Yes good catch, those methods should be private. Thanks! http://gerrit.cloudera.org:8080/#/c/23482/15/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java: http://gerrit.cloudera.org:8080/#/c/23482/15/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@983 PS15, Line 983: boolean[] validity > As discussed offline, instead of boolean array it might be java.util.BitSet Yes, makes sense. We'll address this in a separate patch. http://gerrit.cloudera.org:8080/#/c/23482/15/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@2073 PS15, Line 2073: (byte[][] > this cast is redundant, as the check at 2071 ensures the instance type Done -- To view, visit http://gerrit.cloudera.org:8080/23482 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbe5e243eafe12a8977d40204dacab99624451eb Gerrit-Change-Number: 23482 Gerrit-PatchSet: 15 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 22 Oct 2025 22:11:41 +0000 Gerrit-HasComments: Yes
