Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23601 )
Change subject: KUDU-1261 make ArrayCellMetadataView::Init() more robust ...................................................................... KUDU-1261 make ArrayCellMetadataView::Init() more robust This makes ArrayCellMetadataView::Init() implementation more robust. In particular, it no longer crashes on flatbuffers with empty Content and type set to String or Binary. Neither C++ nor Java client side generates such flatbuffers content as of now, but the code should be robust enough to handle any input. New test scenarios to cover the regression are present as well. In addition, I moved all the code in array_type_serdes-test.cc into kudu::serdes namespace. Change-Id: I1f93e91b0a178fd3701f7ef3c1da855e56bb9f57 Reviewed-on: http://gerrit.cloudera.org:8080/23601 Tested-by: Marton Greber <[email protected]> Reviewed-by: Marton Greber <[email protected]> Reviewed-by: Abhishek Chennaka <[email protected]> --- M src/kudu/common/array_cell_view.h M src/kudu/common/array_type_serdes-test.cc 2 files changed, 190 insertions(+), 42 deletions(-) Approvals: Marton Greber: Looks good to me, approved; Verified Abhishek Chennaka: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/23601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1f93e91b0a178fd3701f7ef3c1da855e56bb9f57 Gerrit-Change-Number: 23601 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]>
