Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/23224 )
Change subject: Add OpenAPI specification for REST API endpoints ...................................................................... Patch Set 10: (11 comments) http://gerrit.cloudera.org:8080/#/c/23224/9/src/kudu/master/rest_catalog-test.cc File src/kudu/master/rest_catalog-test.cc: http://gerrit.cloudera.org:8080/#/c/23224/9/src/kudu/master/rest_catalog-test.cc@673 PS9, Line 673: NO_FATALS(VerifyObjectExists(tables_pat > here and below: wrap this into NO_FATALS() to break out of the scenario rig Done http://gerrit.cloudera.org:8080/#/c/23224/9/src/kudu/master/rest_catalog-test.cc@712 PS9, Line 712: ASSERT_STR_CONTAINS(content, "swagger-ui.css") << "Should include Swagger UI CSS"; : ASSERT_STR_CONTAINS(content, "swagger-ui-bundle.js") << "Should include Swagger UI JS bundle"; : ASSERT_STR_CONTAINS(content, "kudu-swagger-init.js") << "Should include Kudu Swagger init script"; : : ASSERT_STR_CONTAINS(content, "id=\"swa > What are these for? This isn't helping to check for valid HTML, so why bot Good point, removed. http://gerrit.cloudera.org:8080/#/c/23224/9/www/swagger/kudu-api.json File www/swagger/kudu-api.json: PS9: > Does it possible to include information on security for all these documente Done http://gerrit.cloudera.org:8080/#/c/23224/9/www/swagger/kudu-api.json@4 PS9, Line 4: Kudu Master R > Do we call it 'Kudu REST API' as of now? I recall it was something about ' Done http://gerrit.cloudera.org:8080/#/c/23224/9/www/swagger/kudu-api.json@14 PS9, Line 14: /tables > For here and all other endpoints where authentication is applicable (I gues Done http://gerrit.cloudera.org:8080/#/c/23224/9/www/swagger/kudu-api.json@466 PS9, Line 466: "table_name": { : "type": "string", : "description": "Name of the table" : } : }, : "required": ["table_id", "table_name"] : }, : "TableResponse": { : "typ > As a part of KUDU-1261, support for one-dimensional arrays of scalar types In theory it should be possible, since the REST API uses JsonStringToMessage() to parse JSON directly into protobuf. http://gerrit.cloudera.org:8080/#/c/23224/9/www/swagger/kudu-api.json@485 PS9, Line 485: "schema": { > Kudu does have so-called auto-inrementing columns. Is it possible to creat Yes it is! http://gerrit.cloudera.org:8080/#/c/23224/9/www/swagger/kudu-api.json@495 PS9, Line 495: > Where are these 'custom_hash_schema_ranges' defined in this API spec? I co Done http://gerrit.cloudera.org:8080/#/c/23224/9/www/swagger/kudu-api.json@546 PS9, Line 546: re > What is 'id'? Is it at all applicable in this context when providing Colum Ah yes, good catch, the description for this is not correct, I edited it. http://gerrit.cloudera.org:8080/#/c/23224/9/www/swagger/kudu-api.json@562 PS9, Line 562: }, : "description": "Nested data type descriptor. Currently only arrays of scalar types are supported." : }, : "ArrayTypeDescriptor": { : "type": "object", > nit: the indent seems to be wrong? Done http://gerrit.cloudera.org:8080/#/c/23224/9/www/swagger/kudu-api.json@642 PS9, Line 642: "type": "object", : "properties": { : "columns": { : "type": "array", : "items": { : "$ref": "#/components/ > Don't Kudu master REST API support renaming tables? It does yes, it's defined a bit higher in this part: "new_table_name": { "type": "string", "description": "New name for the table", "default": "new_table_name" }, -- To view, visit http://gerrit.cloudera.org:8080/23224 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3981665c78f478e89d0300f3a2fc5d68b73b8762 Gerrit-Change-Number: 23224 Gerrit-PatchSet: 10 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 29 Oct 2025 15:19:34 +0000 Gerrit-HasComments: Yes
