Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23548 )
Change subject: Enable REST API endpoints in webserver crawl test ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/23548/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23548/2//COMMIT_MSG@12 PS2, Line 12: Also added exclusion logic to skip large JavaScript bundles (like : swagger-ui-bundle.js) that would bloat test output without providing : meaningful validation, since serving them already confirms they're : accessible. How much bloat is this? About 1.4MiByte? AFAIK, we do have 'heavy' pages already, e.g. /logs, /metrics_prometheus From the other side, how much difference in runtime of the test could you see with and without swagger-ui-bundle.js? IIUC, the primary purpose of WebserverCrawlITest is not just making sure the URLs are accessible, but rather simulating URL rewriting that Knox would do and make sure the result URLs come out as expected. I'm not against this optimization, but I'm just curious: if not skipping swagger-ui-bundle.js, does the test pass at least? Even if it doesn't, it's not a big deal: per 58177651a4e3ba3da9ddee46ec5e79bc011f8406 the URLs if JS (if any) aren't re-written as of now, so this swagger/OpenAPI page is another one which might not work via Knox then. I'm just curious how dramatic is the impact of this exclusion on the test runtime and whether the test is still passing if not excluding swagger-ui-bundle.js. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/23548 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5be128536d4f104e2d3bfa55c02b81e6f114d5fc Gerrit-Change-Number: 23548 Gerrit-PatchSet: 2 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Thu, 30 Oct 2025 08:04:25 +0000 Gerrit-HasComments: Yes
