Hello Marton Greber, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23616
to look at the new patch set (#2).
Change subject: [java] log test scenario name in TestKuduClient
......................................................................
[java] log test scenario name in TestKuduClient
While trying to decipher logs from failing TestKuduClient in dist-test,
I found it's hard to tell what exact scenario had failed. To address
the issue, this changelist adds the necessary information similar to
what gtest outputs when running C++ tests.
I thought it would be great to do this for all the Java tests, but I
couldn't find a straightforward way to achieve this with JUnit4 if not
copying over the whole TestWatcher boilerplate. Even if that would be
quite a ubiquitous Java-style approach, I'm not ready to do so.
Instead, I think this boilerplate can be added on a test-by-test basis,
when we find it's necessary: the majority of the tests aren't flaky
as of today, and running tests with Gradle's 'test' task allows for
per-scenario reporting already.
Meanwhile, with JUnit5 the Extension concept [2] has been introduced,
and it allows for having the necessary functionality by adding the
@ExtendWith directive instead of copying the whole TestWatcher-related
boilerplate. An upgrade to JUnit6 (or newer) might be an opportunity
to revisit this, if necessary.
[1] https://junit.org/junit4/javadoc/latest/org/junit/rules/TestWatcher.html
[2]
https://docs.junit.org/current/api/org.junit.jupiter.api/org/junit/jupiter/api/extension/Extension.html
Change-Id: I6f4d0e9bf5b590f5f0ce490838658091063e2aea
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/23616/2
--
To view, visit http://gerrit.cloudera.org:8080/23616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6f4d0e9bf5b590f5f0ce490838658091063e2aea
Gerrit-Change-Number: 23616
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
