Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/23608 )
Change subject: KUDU-3662: Add stress test for checkpoint recovery ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/23608/2/java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationCheckpointStress.java File java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationCheckpointStress.java: http://gerrit.cloudera.org:8080/#/c/23608/2/java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationCheckpointStress.java@96 PS2, Line 96: throws Exception Exception is never thrown http://gerrit.cloudera.org:8080/#/c/23608/2/java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationCheckpointStress.java@101 PS2, Line 101: throws Exception Exception is never thrown http://gerrit.cloudera.org:8080/#/c/23608/2/java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationCheckpointStress.java@148 PS2, Line 148: private void insertStressTestData(int iteration, int numRows) currently this method is only called once, so numRows will always be ROWS_PER_ITERATION (as called at #201) so I think it would make sense to remove it as a parameter and just use the constant as is http://gerrit.cloudera.org:8080/#/c/23608/2/java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationCheckpointStress.java@187 PS2, Line 187: getTabletsLocations this method is deprecated, the KuduScanToken api should be used instead -- To view, visit http://gerrit.cloudera.org:8080/23608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic463c143a5330bf8db7c5b026a8b4dbe83b7a769 Gerrit-Change-Number: 23608 Gerrit-PatchSet: 2 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 03 Nov 2025 14:40:21 +0000 Gerrit-HasComments: Yes
