Ashwani Raina has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23647 )

Change subject: [tools] update 'kudu master add' in-line help
......................................................................


Patch Set 1:

(5 comments)

LGTM! Just a few nits.

http://gerrit.cloudera.org:8080/#/c/23647/1//COMMIT_MSG
Commit Message:

PS1:
nit: Maybe slip in the version (1.16.0), here as well, that introduced the 
improvement.


http://gerrit.cloudera.org:8080/#/c/23647/1/src/kudu/tools/tool_action_master.cc
File src/kudu/tools/tool_action_master.cc:

http://gerrit.cloudera.org:8080/#/c/23647/1/src/kudu/tools/tool_action_master.cc@884
PS1, Line 884: at
nit: on


http://gerrit.cloudera.org:8080/#/c/23647/1/src/kudu/tools/tool_action_master.cc@885
PS1, Line 885: at
nit: on


http://gerrit.cloudera.org:8080/#/c/23647/1/src/kudu/tools/tool_action_master.cc@890
PS1, Line 890: that "
             :             "kudu-master runs with
nit: "that a kudu-master can run with" ?


http://gerrit.cloudera.org:8080/#/c/23647/1/src/kudu/tools/tool_action_master.cc@893
PS1, Line 893: supplised
nit: supplied



--
To view, visit http://gerrit.cloudera.org:8080/23647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida92fda5d6d3f4edd9f04796efa090bef7c540bd
Gerrit-Change-Number: 23647
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 06 Nov 2025 12:28:09 +0000
Gerrit-HasComments: Yes

Reply via email to