Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/23609 )
Change subject: [java] Split TestKuduClient into smaller modules ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/23609/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClientAdvanced.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClientAdvanced.java: http://gerrit.cloudera.org:8080/#/c/23609/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClientAdvanced.java@55 PS3, Line 55: ache.kudu.Type; > Here and elsewhere: did you consider inheriting from a single TestKuduClien I considered it, but composition via KuduTestHarness is more flexible. Each test class is self-contained with only what it needs. A base class would force common setup/teardown that doesn't fit all scenarios. -- To view, visit http://gerrit.cloudera.org:8080/23609 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3fcedb050ce4deea1c317b3cf3687502cbe81ce7 Gerrit-Change-Number: 23609 Gerrit-PatchSet: 4 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Fri, 07 Nov 2025 15:15:27 +0000 Gerrit-HasComments: Yes
