Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23651 )
Change subject: [rpc] Fail ipv4 requests when ip mode is 'ipv6' ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/23651/1/src/kudu/rpc/rpc-test.cc File src/kudu/rpc/rpc-test.cc: http://gerrit.cloudera.org:8080/#/c/23651/1/src/kudu/rpc/rpc-test.cc@2326 PS1, Line 2326: s = s6.Connect(target_addr); > Would it be valuable to also test an actual end-to-end RPC call (e.g., usin It is important to have a control over what type of sockets we create in order to test and verify whether connection is accepted or refused based on the IP protocol compatibility as well socket options (e.g. IPv6 mode when only IPv6 connection are served). There is no easy way to enforce the client socket protocol if we go by DoTestSyncCall route. The proxy sends outbounds requests via reactor threads that create client socket based on server family. I am not aware if we have a way to manipulate client socket init parameters so deep in the code from the test here. I don't expect RPC to deviate from this behaviour unless you have some scenario where it could? If there is such a possibility, I would be happy to mull about introducing client socket level customisation code that can be used to verify same sub-test cases. -- To view, visit http://gerrit.cloudera.org:8080/23651 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic84ba301d0faa36e928eec54872d02f28a4f793f Gerrit-Change-Number: 23651 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Tue, 11 Nov 2025 13:59:57 +0000 Gerrit-HasComments: Yes
