Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23655 )
Change subject: Add Introducing REST API blog post ...................................................................... Patch Set 2: (12 comments) http://gerrit.cloudera.org:8080/#/c/23655/2/_posts/2025-11-10-introducing-the-rest-api.md File _posts/2025-11-10-introducing-the-rest-api.md: PS2: For regular text content, could you break long lines so a single line would be of at most 80 characters long? Many prior posts were adhering to such a layout (sometimes using 100 characters instead of 80, though). At least, it's easier to review posts that are formatted as described above. Thank you! http://gerrit.cloudera.org:8080/#/c/23655/2/_posts/2025-11-10-introducing-the-rest-api.md@13 PS2, Line 13: full client application client application that depends on the Kudu client library and uses KRPC to interact with Kudu clusters http://gerrit.cloudera.org:8080/#/c/23655/2/_posts/2025-11-10-introducing-the-rest-api.md@13 PS2, Line 13: catalog system catalog http://gerrit.cloudera.org:8080/#/c/23655/2/_posts/2025-11-10-introducing-the-rest-api.md@13 PS2, Line 13: table-metadata table metadata ? http://gerrit.cloudera.org:8080/#/c/23655/2/_posts/2025-11-10-introducing-the-rest-api.md@24 PS2, Line 24: table metadata management Here and elsewhere in appropriate context: being 'table metadata' from the Kudu's system catalog view, in the outside world of applications and SQL it's usually referred to as 'altering a table', 'DDL operations', etc. Consider rephrasing 'table metadata management' to be more descriptive of what this means to the outside world. http://gerrit.cloudera.org:8080/#/c/23655/2/_posts/2025-11-10-introducing-the-rest-api.md@89 PS2, Line 89: master's web UI Does it make sense to provide path the the API doc page from the root of the embedded webserver? http://gerrit.cloudera.org:8080/#/c/23655/2/_posts/2025-11-10-introducing-the-rest-api.md@89 PS2, Line 89: OpenAPI Consider adding an extra Reference section to provide hyperlinks to OpenAPI and other external resources for the readers' convenience. In addition to OpenAPI link, maybe add references/links to the Kudu C++ and Java client API as well (they are referenced in the beginning of this post). http://gerrit.cloudera.org:8080/#/c/23655/2/_posts/2025-11-10-introducing-the-rest-api.md@96 PS2, Line 96: will return errors Maybe, be more specific as for what particular HTTP status code non-leader masters respond with? http://gerrit.cloudera.org:8080/#/c/23655/2/_posts/2025-11-10-introducing-the-rest-api.md@96 PS2, Line 96: only the leader master will respond to REST API requests Non-leader masters respond as well, but they respond with errors, IIUC. Please rephrase this part of the sentence to be technically correct. http://gerrit.cloudera.org:8080/#/c/23655/2/_posts/2025-11-10-introducing-the-rest-api.md@96 PS2, Line 96: connect to the correct master Since it's not quite evident for people without Kudu or other distributed systems background, consider mentioning that leader master might change at any time, and it's necessary to find a new leader and change the destination URL once receiving particular HTTP status code from the Kudu master that the application received the error. http://gerrit.cloudera.org:8080/#/c/23655/2/_posts/2025-11-10-introducing-the-rest-api.md@96 PS2, Line 96: configurations Kudu clusters http://gerrit.cloudera.org:8080/#/c/23655/2/_posts/2025-11-10-introducing-the-rest-api.md@99 PS2, Line 99: for optimal performance nit: drop this part? -- To view, visit http://gerrit.cloudera.org:8080/23655 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: I1435431857a9f493e6492fae002c70f7af4cdd6c Gerrit-Change-Number: 23655 Gerrit-PatchSet: 2 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Tue, 18 Nov 2025 00:12:25 +0000 Gerrit-HasComments: Yes
