Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23696 )
Change subject: [rpc,util] __thread --> thread_local ...................................................................... [rpc,util] __thread --> thread_local This patch changes '__thread' GCC-specific extension to the C++11-based 'thread_local' for better portability. At supported platforms, Kudu de facto compiles with GCC/G++ and CLANG only (both support '__thread' and treat it the same as 'thread_local'), but it doesn't hurt to have more portable code. I also fixed typo in service_queue.h and changed include guards to 'pragma once' in threadlocal.h and striped64.h. There are no functional modifications in this changelist. Change-Id: I237f707f2a8755796ad14effeef007c670641643 Reviewed-on: http://gerrit.cloudera.org:8080/23696 Tested-by: Kudu Jenkins Reviewed-by: Ashwani Raina <[email protected]> Reviewed-by: Abhishek Chennaka <[email protected]> --- M src/kudu/rpc/sasl_common.cc M src/kudu/rpc/service_queue.h M src/kudu/util/debug/trace_event_impl.cc M src/kudu/util/debug/trace_event_impl.h M src/kudu/util/debug/unwind_safeness.cc M src/kudu/util/env_posix.cc M src/kudu/util/kernel_stack_watchdog.cc M src/kudu/util/logging.cc M src/kudu/util/logging.h M src/kudu/util/spinlock_profiling.cc M src/kudu/util/striped64.cc M src/kudu/util/striped64.h M src/kudu/util/thread.cc M src/kudu/util/thread.h M src/kudu/util/threadlocal.h M src/kudu/util/threadlocal_cache.h M src/kudu/util/trace.cc M src/kudu/util/trace.h 18 files changed, 34 insertions(+), 40 deletions(-) Approvals: Kudu Jenkins: Verified Ashwani Raina: Looks good to me, but someone else must approve Abhishek Chennaka: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/23696 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I237f707f2a8755796ad14effeef007c670641643 Gerrit-Change-Number: 23696 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]>
