Ashwani Raina has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23529 )

Change subject: KUDU-1973 Enable some unit tests for heartbeat batching.
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23529/4/src/kudu/integration-tests/raft_consensus-itest.cc
File src/kudu/integration-tests/raft_consensus-itest.cc:

http://gerrit.cloudera.org:8080/#/c/23529/4/src/kudu/integration-tests/raft_consensus-itest.cc@250
PS4, Line 250: if user explicitly set the flag on the command line, do not run 
both version.
Out of curiosity: when the test is running, why would user set the flag on a 
server from the command line?


http://gerrit.cloudera.org:8080/#/c/23529/4/src/kudu/integration-tests/raft_consensus-itest.cc@252
PS4, Line 252: && GetParam()
nit: align



--
To view, visit http://gerrit.cloudera.org:8080/23529
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd442b36b46c038fbf836f48feaa21b1ab296d82
Gerrit-Change-Number: 23529
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Martonka <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Comment-Date: Fri, 21 Nov 2025 14:43:53 +0000
Gerrit-HasComments: Yes

Reply via email to