Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23748 )
Change subject: KUDU-3722 unit mismatch in ProceedWithFlush ...................................................................... KUDU-3722 unit mismatch in ProceedWithFlush MaintenanceManager's ProceedWithFlush function uses units inconsistent with process_memory::UnderMemoryPressure when checking memory pressure: soft_limit and pressure_threshold are treated as decimals (0–1) while used_memory_percentage is a percentage (0–100). This causes ProceedWithFlush to always return true once memory usage exceeds memory_pressure_percentage, which is not the intended behavior introduced by KUDU-3407. This patch converts soft_limit and pressure_threshold to percentages, replaces division with an equivalent multiplication form, and updates the relevant tests. Change-Id: Icb4c299a83c61bd934d67f32446696988bbe3a08 Reviewed-on: http://gerrit.cloudera.org:8080/23726 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> (cherry picked from commit 6799d13cc53190604d141ca1ebf26882edb3b88a) Reviewed-on: http://gerrit.cloudera.org:8080/23748 Reviewed-by: Zoltan Martonka <[email protected]> Reviewed-by: Abhishek Chennaka <[email protected]> --- M src/kudu/util/maintenance_manager-test.cc M src/kudu/util/maintenance_manager.cc 2 files changed, 23 insertions(+), 20 deletions(-) Approvals: Zoltan Martonka: Looks good to me, but someone else must approve Alexey Serbin: Verified Abhishek Chennaka: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/23748 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.18.x Gerrit-MessageType: merged Gerrit-Change-Id: Icb4c299a83c61bd934d67f32446696988bbe3a08 Gerrit-Change-Number: 23748 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yongheng Deng <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]>
