Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23707 )
Change subject: KUDU-1457 [8/n] Parameterize tests with ip config ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/23707/3/src/kudu/master/mini_master-test.cc File src/kudu/master/mini_master-test.cc: http://gerrit.cloudera.org:8080/#/c/23707/3/src/kudu/master/mini_master-test.cc@42 PS3, Line 42: std::ostream& operator<<(std::ostream& os, IPMode param) { : string param_name = GetIPConfigMode(param); : return os << param_name; : } To avoid code duplication the operator<< should be defined once in a common location. http://gerrit.cloudera.org:8080/#/c/23707/3/src/kudu/server/webserver-test.cc File src/kudu/server/webserver-test.cc: http://gerrit.cloudera.org:8080/#/c/23707/3/src/kudu/server/webserver-test.cc@1132 PS3, Line 1132: switch (GetParam()) { : case IPMode::IPV6: : opts.bind_interface = "[::1]"; : break; : case IPMode::DUAL: : opts.bind_interface = "[::]"; : break; : default: : // Default value of FLAGS_webserver_interface i.e., IPv4 wildcard. : break; : } Shouldn't this happen before constructing Webserver object? -- To view, visit http://gerrit.cloudera.org:8080/23707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic72efea2045b12300ccf0e80873c405828c15a30 Gerrit-Change-Number: 23707 Gerrit-PatchSet: 3 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Wed, 17 Dec 2025 17:05:26 +0000 Gerrit-HasComments: Yes
