Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23819 )
Change subject: [codegen] encode projection key once ...................................................................... [codegen] encode projection key once There is no need to encode row projection key multiple times: one time when scheduling a compilation task, another time when running it, and one more time when inserting a new entry into the codegen cache. The latter two steps were done by the same thread in the codegen compilation pool, and there is just a single thread in the pool. Apparently, it's better to encode the key only once by the thread which schedules the compilation task upon requesting the corresponding row projection. With this update, there isn't a need for JITWrapper::EncodeOwnKey() method anymore. Change-Id: Ief2a1cf184c86c33031f90d92a10755da3e86e0b Reviewed-on: http://gerrit.cloudera.org:8080/23819 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Zoltan Martonka <[email protected]> Reviewed-by: Ashwani Raina <[email protected]> Reviewed-by: Abhishek Chennaka <[email protected]> --- M src/kudu/codegen/code_cache.cc M src/kudu/codegen/code_cache.h M src/kudu/codegen/compilation_manager.cc M src/kudu/codegen/jit_wrapper.h M src/kudu/codegen/row_projector.h 5 files changed, 42 insertions(+), 54 deletions(-) Approvals: Alexey Serbin: Verified Zoltan Martonka: Looks good to me, but someone else must approve Ashwani Raina: Looks good to me, but someone else must approve Abhishek Chennaka: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/23819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ief2a1cf184c86c33031f90d92a10755da3e86e0b Gerrit-Change-Number: 23819 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka <[email protected]>
