Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/23820 )
Change subject: [codegen] relax memory ordering for metric updates
......................................................................
[codegen] relax memory ordering for metric updates
Since 'code_cache_hits' and 'code_cache_queries' are used as metric
gauges only and aren't consumed in any way that would require strong
consistency guarantees, it makes sense to switch from the
'memory_order_seq_cst' to the 'memory_order_relaxed' when updating
the underlying '{hit,query}_counter_' atomic counters.
Change-Id: Id874786ff5c6f83c1b84b747064808e2d939d3fb
Reviewed-on: http://gerrit.cloudera.org:8080/23820
Reviewed-by: Zoltan Martonka <[email protected]>
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Abhishek Chennaka <[email protected]>
---
M src/kudu/codegen/compilation_manager.cc
1 file changed, 9 insertions(+), 8 deletions(-)
Approvals:
Zoltan Martonka: Looks good to me, but someone else must approve
Alexey Serbin: Verified
Abhishek Chennaka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/23820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id874786ff5c6f83c1b84b747064808e2d939d3fb
Gerrit-Change-Number: 23820
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
