Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/23844 )
Change subject: [tools] Add --preserve_table_ids flag to unsafe_rebuild ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/23844/4/src/kudu/tools/master_rebuilder.cc File src/kudu/tools/master_rebuilder.cc: http://gerrit.cloudera.org:8080/#/c/23844/4/src/kudu/tools/master_rebuilder.cc@61 PS4, Line 61: If true, preserve the original table IDs from the " : "tablet servers' metadata instead of generating new ones. This is useful when you " : "need to maintain compatibility with external systems (e.g., Impala, HMS) that " : "reference tables by their original IDs. The flag description mentions external systems, but based on the commit message, the main driver for this feature seems to be Kudu's own --tserver_enforce_access_control. Would it make sense to mention the access control use case in the flag help text? I'm thinking operators might not realize they need this flag if they have access control enabled, and could end up with a broken cluster after rebuild. What do you think? http://gerrit.cloudera.org:8080/#/c/23844/4/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/23844/4/src/kudu/tools/tool_action_master.cc@53 PS4, Line 53: #include "kudu/tablet/tablet-test-util.h" Is this test utility header used anywhere in this file? -- To view, visit http://gerrit.cloudera.org:8080/23844 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ae4353564922312d646f0323271d804e32e3b0d Gerrit-Change-Number: 23844 Gerrit-PatchSet: 4 Gerrit-Owner: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yan-Daojiang <[email protected]> Gerrit-Comment-Date: Tue, 13 Jan 2026 11:04:42 +0000 Gerrit-HasComments: Yes
