Ashwani Raina has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23710 )

Change subject: KUDU-1457 [6/n] Enable IPv6-only mode for webserver
......................................................................


Patch Set 2:

> Patch Set 2:
>
> What’s the point of adding tests?
> We don’t run them — or do we?

We don't run them in cadence but it wouldn't harm to run the unit tests if we 
add any changes to squeasel code. It proved to be quite handy as I was able to 
catch a few errors and fix using unit tests.

A number of tests have been added in a previous patch as well:
https://gerrit.cloudera.org/c/23016/8/thirdparty/patches/squeasel-support-get-bound-addresses-for-ipv6.patch


--
To view, visit http://gerrit.cloudera.org:8080/23710
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3db4195c82ee1e7843a3ea84681e080905030eb7
Gerrit-Change-Number: 23710
Gerrit-PatchSet: 2
Gerrit-Owner: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
Gerrit-Comment-Date: Tue, 13 Jan 2026 11:41:56 +0000
Gerrit-HasComments: No

Reply via email to