Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23876 )
Change subject: [net] make SockAddr::HashCode() return size_t ...................................................................... [net] make SockAddr::HashCode() return size_t This patch changes the return type of SockAddr::HashCode() from uint32_t to size_t (since the underlying hash function effectively operates with 64-bit integers on x86_64 anyway) and brings more consistency into the specialization of the std::hash<T>::operator()(const T&) for the Sockaddr type. This addresses UBSAN warnings on implicit conversion of integers (when enabled) and makes SockAddr::HashCode() consistent with the expectations for std::hash<T>::operator() template specialization. Change-Id: Ia228dfd6cf932a2378ba7e7cafbc07a381313c12 Reviewed-on: http://gerrit.cloudera.org:8080/23876 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Abhishek Chennaka <[email protected]> --- M src/kudu/util/net/sockaddr.cc M src/kudu/util/net/sockaddr.h 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: Alexey Serbin: Verified Abhishek Chennaka: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/23876 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia228dfd6cf932a2378ba7e7cafbc07a381313c12 Gerrit-Change-Number: 23876 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
