Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23893 )
Change subject: KUDU-3736 add CodegenTest.CodegenRandomSchemas scenario ...................................................................... Patch Set 6: (2 comments) Thank you for taking a look1 http://gerrit.cloudera.org:8080/#/c/23893/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23893/6//COMMIT_MSG@7 PS6, Line 7: add CodegenTest.CodegenRandomSchemas scenario > Are you planning to add some more unit tests in this patch, for newly added I'm not planning to add more unit tests related to review item 23925 in this patch. If adding those, they will come in a separate changelist. http://gerrit.cloudera.org:8080/#/c/23893/6/src/kudu/codegen/codegen-test.cc File src/kudu/codegen/codegen-test.cc: http://gerrit.cloudera.org:8080/#/c/23893/6/src/kudu/codegen/codegen-test.cc@74 PS6, Line 74: 60 > Is it possible to see crash while this runs for 60 seconds? Yes, it is. I've seen this test crashing in under 10 seconds if running without KUDU-3736 fix. From running this test prior to KUDU-3736 fix, I saw one in every five runs crashing in under 60 seconds (RELEASE builds), so I think 60 seconds is good enough to allow for KUDU-3736 regression to manifest itself. And remember: the Apache Kudu also have the flaky tests dashboard in addition to all the regular pre-commit runs. > If there is a possibility of crash, should that be handled via some _DEATH > assertion? There isn't a possibility of crash if running with KUDU-3736 fix (assuming there is no regression), and this patch is on top of KUDU-3736 fix already. So, there is no need for any DEATH-style assertions here. -- To view, visit http://gerrit.cloudera.org:8080/23893 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic51e8fec02f74ecc11fa740f05ffeb9a7f41d8d9 Gerrit-Change-Number: 23893 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 03 Feb 2026 22:17:13 +0000 Gerrit-HasComments: Yes
