Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23707 )
Change subject: KUDU-1457 [8/n] Parameterize tests with ip config ...................................................................... KUDU-1457 [8/n] Parameterize tests with ip config This patch enables IP based tests to take constants instead of strings for paramterization, thereby, adding type-safety and improved compile time checks. Convert parameter type to readable string to improve readability. Add helper function to convert IPMode value to its corresponding string value that can be directly used to set the ip_config_mode flag. Change-Id: Ic72efea2045b12300ccf0e80873c405828c15a30 Reviewed-on: http://gerrit.cloudera.org:8080/23707 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/master/mini_master-test.cc M src/kudu/server/webserver-test.cc M src/kudu/util/net/net_util-test.cc M src/kudu/util/net/net_util.cc M src/kudu/util/net/net_util.h M src/kudu/util/test_util.cc M src/kudu/util/test_util.h 7 files changed, 106 insertions(+), 74 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/23707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic72efea2045b12300ccf0e80873c405828c15a30 Gerrit-Change-Number: 23707 Gerrit-PatchSet: 9 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]>
