Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21073 )
Change subject: Remove the replace flag if the move fails in auto rebalancing. ...................................................................... Patch Set 16: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21073/16/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/21073/16/src/kudu/master/auto_rebalancer.cc@746 PS16, Line 746: rpc Shouldn't this rpc controller have a timeout set? I've checked, all other rpc controllers in this file and all use this value: rpc.set_timeout(MonoDelta::FromSeconds(FLAGS_auto_rebalancing_rpc_timeout_seconds)); -- To view, visit http://gerrit.cloudera.org:8080/21073 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I99dafa654878b9d6d8162d84500913ae0655692b Gerrit-Change-Number: 21073 Gerrit-PatchSet: 16 Gerrit-Owner: Song Jiacheng <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Song Jiacheng <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Comment-Date: Mon, 09 Feb 2026 17:46:05 +0000 Gerrit-HasComments: Yes
