Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/24040 )
Change subject: [infra] Update build-and-test.sh for Java 17 ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/24040/1/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/24040/1/build-support/jenkins/build-and-test.sh@274 PS1, Line 274: echo "jenv is required when BUILD_JAVA=1, but it was not found in PATH." If it is required, then why dont we exit with a non-zero error code here? http://gerrit.cloudera.org:8080/#/c/24040/1/build-support/jenkins/build-and-test.sh@283 PS1, Line 283: [nit] fix spaces http://gerrit.cloudera.org:8080/#/c/24040/1/build-support/jenkins/build-and-test.sh@285 PS1, Line 285: USE_JDK17=$(git show|egrep '^\s{4}USE_JDK17') Why do you require exactly 4 white spaces before the tag? It feels really painful. Why do you scan the diff to? Use: git show -s --format=%B to only grep the commit message. http://gerrit.cloudera.org:8080/#/c/24040/1/build-support/jenkins/build-and-test.sh@286 PS1, Line 286: if [ "x$DONT_BUILD" != "x" ]; then Should this not be??? if [ "$USE_JDK17" != "x" ]; then -- To view, visit http://gerrit.cloudera.org:8080/24040 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1d6d65fbd58a8c96d1dca958fc66207893bb99e Gerrit-Change-Number: 24040 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Mon, 02 Mar 2026 12:58:10 +0000 Gerrit-HasComments: Yes
