Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/23909 )
Change subject: KUDU-3728 Add range-aware rebalancing to auto_rebalancer ...................................................................... Patch Set 6: (9 comments) http://gerrit.cloudera.org:8080/#/c/23909/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23909/5//COMMIT_MSG@16 PS5, Line 16: tablets : ar > unexpected line break? Done http://gerrit.cloudera.org:8080/#/c/23909/5/src/kudu/master/auto_rebalancer-test.cc File src/kudu/master/auto_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/23909/5/src/kudu/master/auto_rebalancer-test.cc@267 PS5, Line 267: > nit: add 'using std::map;' in the beginning of this file and drop the names Done http://gerrit.cloudera.org:8080/#/c/23909/5/src/kudu/master/auto_rebalancer-test.cc@270 PS5, Line 270: con > nit: there is 'using std::vector', so no namespace prefix is necessary Done http://gerrit.cloudera.org:8080/#/c/23909/5/src/kudu/master/auto_rebalancer-test.cc@276 PS5, Line 276: atic > ditto for the namespace prefix Done http://gerrit.cloudera.org:8080/#/c/23909/5/src/kudu/master/auto_rebalancer-test.cc@287 PS5, Line 287: if (ta > ditto for the namespace prefix Done http://gerrit.cloudera.org:8080/#/c/23909/5/src/kudu/master/auto_rebalancer-test.cc@288 PS5, Line 288: e; > nit: consider using structured binding here Done http://gerrit.cloudera.org:8080/#/c/23909/5/src/kudu/master/auto_rebalancer-test.cc@368 PS5, Line 368: workload_->Setup(); : } : : void TearDown() override { : if (cluster_) { : cluster_->Shutdown(); : } : // Restore any flags after the cluster is fully shut down. : flag_saver_.reset(); : KuduTest::TearDown(); : } : : protected: : u > I didn't pay attention to this in the prior review rounds, but I just reali Done http://gerrit.cloudera.org:8080/#/c/23909/5/src/kudu/master/auto_rebalancer-test.cc@658 PS5, Line 658: ASSERT_OK(CreateAndStartCluster()); > Thank you for adding this new scenario! Thank you for the suggestion! http://gerrit.cloudera.org:8080/#/c/23909/5/src/kudu/master/auto_rebalancer-test.cc@709 PS5, Line 709: ASSER > nit: you could omit this because there is corresponding 'using' directive i Done -- To view, visit http://gerrit.cloudera.org:8080/23909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf716bef8c21395da98dd7c9e33001190d9b5587 Gerrit-Change-Number: 23909 Gerrit-PatchSet: 6 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 03 Mar 2026 16:46:41 +0000 Gerrit-HasComments: Yes
