Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/24034 )
Change subject: Add swagger verification test target ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/24034/3/src/kudu/master/CMakeLists.txt File src/kudu/master/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/24034/3/src/kudu/master/CMakeLists.txt@149 PS3, Line 149: ADD_KUDU_TEST(verify_swagger_spec-test.sh LABELS no_dist_test) > nit: move this to keep the ADD_KUDU_TESET lines ordered alphabetically by t Done http://gerrit.cloudera.org:8080/#/c/24034/3/src/kudu/master/verify_swagger_spec-test.sh File src/kudu/master/verify_swagger_spec-test.sh: http://gerrit.cloudera.org:8080/#/c/24034/3/src/kudu/master/verify_swagger_spec-test.sh@24 PS3, Line 24: :- > Why to have this notation? A variable in a Bourne shell is empty if it's n Because the script uses set -u, referencing an unset variable would error. ${KUDU_HOME:-} safely expands to empty, so the check works even when the var isn’t defined. http://gerrit.cloudera.org:8080/#/c/24034/3/src/kudu/master/verify_swagger_spec-test.sh@24 PS3, Line 24: KUDU_SOURCE_ROOT > There is an already established shell variable called KUDU_HOME that's used Good point! I switched the override to that and removed KUDU_SOURCE_ROOT. -- To view, visit http://gerrit.cloudera.org:8080/24034 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f5523eb1fa6792cd81e469169962704d0d27e3b Gerrit-Change-Number: 24034 Gerrit-PatchSet: 3 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Fri, 06 Mar 2026 13:20:48 +0000 Gerrit-HasComments: Yes
