Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24072 )
Change subject: [common] remove ignored 'const' qualifier on return type ...................................................................... [common] remove ignored 'const' qualifier on return type Adding 'const' qualifier for an rvalue return type doesn't make much sense, and it's ignored by the compiler. This changelist removes such qualifiers to avoid warnings issued by the C++ compiler when -Wignored-qualifiers flag is present, for example: src/kudu/rpc/inbound_call.h:103:3: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers] Just in case, I verified that the generated symbols for the kudu_client library stay the same before and after this patch. As expected, this patch doesn't affect the generated symbols, so this doesn't introduce any compatibility in the C++ client ABI. This changelist doesn't contain any functional modifications. Change-Id: I605f13d489d63269df43eb8102488630ceeff6ce Reviewed-on: http://gerrit.cloudera.org:8080/24072 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Abhishek Chennaka <[email protected]> --- M src/kudu/client/schema.cc M src/kudu/client/schema.h M src/kudu/common/row_changelist.h M src/kudu/common/schema.h M src/kudu/fs/file_block_manager.h M src/kudu/fs/log_block_manager.h M src/kudu/rpc/inbound_call.h M src/kudu/util/jsonreader.cc 8 files changed, 11 insertions(+), 11 deletions(-) Approvals: Alexey Serbin: Verified Abhishek Chennaka: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/24072 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I605f13d489d63269df43eb8102488630ceeff6ce Gerrit-Change-Number: 24072 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka <[email protected]>
